Add convenience functions #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
approved these changes
May 7, 2022
| go (Loop a) = go (f a) | ||
| go (Done b) = b | ||
|
|
||
| -- | Create a pure tail-recursive function of two arguments |
Contributor
There was a problem hiding this comment.
Could you add docs that refer to loop2 here? Otherwise, it's not immediately clear that one would know to use loop2 in tandem with tailRec2
| tailRec2 :: forall a b c. (a -> b -> Step { a :: a, b :: b } c) -> a -> b -> c | ||
| tailRec2 f a b = tailRec (\o -> f o.a o.b) { a, b } | ||
|
|
||
| -- | Create a pure tail-recursive function of three arguments |
Contributor
There was a problem hiding this comment.
Similarly here for loop3?
`tailRec2` and `tailRec3` complete the `tailRec` and `tailRecM` matrix, and `loop2` and `loop3` are new conveniences for both `tailRec2/3` and `tailRecM2/3` that better abstract the consumer away from the details of the `a`, `b`, `c` record labels we use in those functions.
rhendric
force-pushed
the
rhendric/tailRec2-etc
branch
from
39c7ba6 to
5ac167d
Compare
Contributor
|
This was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tailRec2andtailRec3complete thetailRecandtailRecMmatrix,and
loop2andloop3are new conveniences for bothtailRec2/3andtailRecM2/3that better abstract the consumer away from the details ofthe
a,b,crecord labels we use in those functions.Description of the change
Submitting this for discussion in preparation for doing something about purescript/purescript#4289. All of these new functions are optional for that proposal, but before we go hard on promoting
purescript-tailrecas the best way to ensure that one's stack-hungry functions execute safely, I think we should address these rough edges, and standardizing on them will make it possible to optimize them out.Checklist: