Update socket rocket to 0.4 #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated iOS deployment target from 5.0 to 6.0. Ran `pod install` with cocoapods 0.38.2 leading to lots of shuffling around of files and renmaing of some files. Removed some duplicated build phases for libPusher target.
…ons of OSX build phases
|
The fix for _openConnection _closeConnection has been merged in SocketRocket. |
Contributor
|
Looks good to me so far, we should also include in this PR a bump of the main library up to 1.6.1. |
Contributor
Author
|
Bumped the version of SocketRocket to 0.4.1 and the version of the pod itself to 1.6.1. Think I got all the references but could do with you checking it if possible @lukeredpath |
lukeredpath
added a commit
that referenced
this pull request
Sep 21, 2015
Update socket rocket to 0.4
Contributor
|
v1.6.1 now available via cocoapods, I still need to create a binary release though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests still pass and I tried it out in the sample app and everything looked to be working as expected.
Also fixed a few other things as I came to them, as noted in the commit messages.