Fix header imports of SocketRocket.h #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @opfeffer. Thanks very much for the PR. That looks good to me, I'll merge it now. The tests aren't passing on master currently, so I'm going to fix those and then I'll release a new version. |
Contributor
|
Hi @opfeffer. I've released that fix now. Let me know if you have any problems. |
Contributor
Author
Thank you so much @TomKemp - say, will you push 1.6.4 to cocoapods master spec repo as well? I see 1.6.3 still being the latest there. https://cocoapods.org/pods/libPusher |
Contributor
|
I pushed it to cocoapods earlier on. Does a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CocoaPods 1.7.0 added "Multiple Xcodeproj Generation" for large projects (see http://blog.cocoapods.org/CocoaPods-1.7.0-beta/#multiple-xcodeproj-generation). To enable, one can add the following line to one's
Podfile:However, enabling it leads to compilation errors in the latest version of this library (
libPusher v1.6.3):This is due to
libPusherimportingSocketRocket.hwithout clearly indicating its coming from another framework.@TomKemp could you take a look? I see that the last published version is more than two years old, so I'm not sure if this library is still actively maintained, but I'd appreciate if this PR could get merged and a new release published to cocoapods master spec repo. Thanks