Add server handling of HTTP status code 204#580
Merged
jjlawren merged 1 commit intopushingkarmaorg:masterfrom Oct 8, 2020
Merged
Add server handling of HTTP status code 204#580jjlawren merged 1 commit intopushingkarmaorg:masterfrom
jjlawren merged 1 commit intopushingkarmaorg:masterfrom
Conversation
SuperRiderTH
added a commit
to SuperRiderTH/resound
that referenced
this pull request
Nov 1, 2020
Newer versions of the Plex Media Server return HTTP status code 204 when deleting a playlist. This causes PlexAPI versions 4.1.2 and lower to throw a BadRequest exception. We now check the PlexAPI version to see if we need to work around this issue or not. This was fixed in the PlexAPI with pushingkarmaorg/python-plexapi#580, so we will assume that a version higher than 4.1.2 will contain this fix.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that newer versions of the Plex server now return HTTP status code 204 when deleting a playlist. It must have been 200 or 201 previously. The client and myplex endpoints already handle this code.
Found in today's CI runs of #530.