Skip to content

Remove unnecessary **kwargs from spa_python and get_total_irradiance #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kandersolar merged 4 commits into from
Apr 6, 2022
Merged

Remove unnecessary **kwargs from spa_python and get_total_irradiance #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b48364
Update Solarposition.py
Naman-Priyadarshi Mar 30, 2022
310c0a5
Added v0.9.2.rst, changes in pvlib/irradiance.py and pvlib/location.py
Naman-Priyadarshi Apr 5, 2022
3a0a8cc
Update docs/sphinx/source/whatsnew/v0.9.2.rst
kandersolar Apr 6, 2022
e21b079
Update docs/sphinx/source/whatsnew/v0.9.2.rst
kandersolar Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions docs/sphinx/source/whatsnew/v0.9.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
.. _whatsnew_0920:

v0.9.2 (TBD)
-----------------------

Deprecations
~~~~~~~~~~~~

Enhancements
~~~~~~~~~~~~

Bug fixes
~~~~~~~~~
* :py:func:`pvlib.irradiance.get_total_irradiance` and
:py:func:`pvlib.solarposition.spa_python` now raise an error instead
of silently ignoring unknown parameters (:ghpull:`1437`)

Testing
~~~~~~~

Documentation
~~~~~~~~~~~~~

Requirements
~~~~~~~~~~~~

Contributors
~~~~~~~~~~~~
* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`)
2 changes: 1 addition & 1 deletion pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def get_total_irradiance(surface_tilt, surface_azimuth,
dni, ghi, dhi, dni_extra=None, airmass=None,
albedo=.25, surface_type=None,
model='isotropic',
model_perez='allsitescomposite1990', **kwargs):
model_perez='allsitescomposite1990'):
r"""
Determine total in-plane irradiance and its beam, sky diffuse and ground
reflected components, using the specified sky diffuse irradiance model.
Expand Down
3 changes: 1 addition & 2 deletions pvlib/location.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,7 @@ def get_clearsky(self, times, model='ineichen', solar_position=None,
pressure = atmosphere.alt2pres(self.altitude)

if solar_position is None:
solar_position = self.get_solarposition(times, pressure=pressure,
**kwargs)
solar_position = self.get_solarposition(times, pressure=pressure)

apparent_zenith = solar_position['apparent_zenith']
apparent_elevation = solar_position['apparent_elevation']
Expand Down
2 changes: 1 addition & 1 deletion pvlib/solarposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def _spa_python_import(how):

def spa_python(time, latitude, longitude,
altitude=0, pressure=101325, temperature=12, delta_t=67.0,
atmos_refract=None, how='numpy', numthreads=4, **kwargs):
atmos_refract=None, how='numpy', numthreads=4):
"""
Calculate the solar position using a python implementation of the
NREL SPA algorithm.
Expand Down