Skip to content

Conversation

@ramaroesilva
Copy link
Contributor

Differently from what was originally discussed with @cwhanse and @echedey-ls, I decided not to include a verification on whether both k and noct are provided within get_cell_temperature. imo, this type of verification should be (and is) done within the temperature.ross function itself and we see that the opposite situation - expected parameters not being provided - is never verified within get_cell_temperature as I imagine it is done within each temperature model function.

@cwhanse about wind and ross model, if that's okay I still included a small note in the wind_speed description to alert ross users that providing a None is enough.


temperature_cell = func(poa_global, temp_air, wind_speed,
*required, **optional)
if model == 'ross':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although wind speed was kept as an input requested by get_cell_temperature, here such a differentiation is needed since ross is apparently the only model not using wind.

@ramaroesilva
Copy link
Contributor Author

ramaroesilva commented Dec 21, 2025

Have included tests for the added temperature models.

@adriesse, for the faiman_rad case could you suggest one set of example ir_down/u0/y1 values for testing? I'm asking this because of this note on the faiman_rad docstring:

When only irradiance, air temperature and wind speed inputs are provided (ir_down is None) this function calculates the same device temperature as the original faiman model. When down-welling long-wave radiation data are provided as well (ir_down is not None) the default u0 and u1 values from the original model should not be used because a portion of the radiative losses would be double-counted.

Afterwards, I can get the expected output by running pvlib.temperature.faiman_rad for poa_global=1000, temp_air=25, wind_speed=1, and your recommended parameter values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pvlib.pvsystem.Array.get_cell_temperature does not accept ross and faiman_rad models

2 participants