-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adds faiman_rad and ross models to get_cell_temperature(). #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| temperature_cell = func(poa_global, temp_air, wind_speed, | ||
| *required, **optional) | ||
| if model == 'ross': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although wind speed was kept as an input requested by get_cell_temperature, here such a differentiation is needed since ross is apparently the only model not using wind.
|
Have included tests for the added temperature models. @adriesse, for the
Afterwards, I can get the expected output by running pvlib.temperature.faiman_rad for |
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Differently from what was originally discussed with @cwhanse and @echedey-ls, I decided not to include a verification on whether both k and noct are provided within
get_cell_temperature. imo, this type of verification should be (and is) done within thetemperature.rossfunction itself and we see that the opposite situation - expected parameters not being provided - is never verified withinget_cell_temperatureas I imagine it is done within each temperature model function.@cwhanse about wind and
rossmodel, if that's okay I still included a small note in thewind_speeddescription to alertrossusers that providing aNoneis enough.