Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Aug 13, 2018

  • Closes Improve performance of solarposition.ephemeris #512
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added this to the 0.6.0 milestone Aug 13, 2018
@wholmgren wholmgren requested a review from cwhanse August 13, 2018 14:42
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wholmgren thanks for fixing this

@wholmgren wholmgren merged commit 10339ee into pvlib:master Aug 14, 2018
@wholmgren wholmgren deleted the ephemspeed branch August 14, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants