Merged
Conversation
Owner
|
Thanks a lot for this PR. I had a busy time the last few weeks, so I didn't find the time to merge it. |
Contributor
Author
|
haha i totally forgot i did this pr. thanks for merging it! |
Owner
|
Me too. Just stumbled upon it a few days ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using
clonein our logger: https://github.com/purposeindustries/node-logify-logstash-transport/blob/master/index.js#L20If we are trying to clone a
http.ServerResponseinstance the module will throw an exception, becauseheadersSentproperty has only getter: https://github.com/joyent/node/blob/7c0419730b237dbfa0ec4e6fb33a99ff01825a8f/lib/_http_outgoing.js#L398-L402The added code does the follow:
protovariable if it has prototype or we can figure it outObject.createalready created the getter on child.)