Fix a bug in _readInlineImage #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 3, 2016 15:17
…nd Q, but were not checking to ensure that there was whitespace between EI and Q. Accordingly, any image that had EIQ in its ascii encoded data would trigger the end of the image, and cause errors.
Collaborator
|
Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_readInlineImage fails for any image that has "EIQ" inside of it.
In the in function
_readInlineImage, we were looking for the operationEIandQ. However, we were not checking to ensure that there was whitespace betweenEIandQ. Accordingly, any image that hadEIQin its ascii encoded data would trigger the end of the image, and cause errors.This fix changes that.
Also, added a small nit change to remove extraneous zeros from our output formatting. These can needlessly bloat the size of the PDF and hurt readability.