feat: add top level Application.context#145
Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom Nov 6, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 1761 1781 +20
=========================================
+ Hits 1761 1781 +20
☔ View full report in Codecov by Sentry. |
Member
Author
|
cc @lucyleeow, this is (in-part) addressing #142 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
Application.contextattribute. It can serve as a natural place for applications to put a top level context (and, as usual, they can spawn children contexts withcontext.new_child).it does not yet hook up context.changed signals to anything in the Qt backend. mostly because I think more consideration of context "scoping" is necessary. For example, it's not obvious that
app.contextis the "correct" context to pass to one of theupdate_from_contextmethods... it might be a more narrowly scoped child context provided by the user.