fix: catch runtime error on QModelSubmenu cleanup#151
Merged
tlambert03 merged 1 commit intopyapp-kit:mainfrom Nov 5, 2023
Merged
fix: catch runtime error on QModelSubmenu cleanup#151tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03 merged 1 commit intopyapp-kit:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 1761 1763 +2
=========================================
+ Hits 1761 1763 +2
☔ View full report in Codecov by Sentry. |
tlambert03
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #147
There may be other/better ways to fix it. Specifically, we could add a new
menus_removedsignal to the MenuRegistry, and emit that instead ofmenu_changedhere:app-model/src/app_model/registries/_menus_reg.py
Line 71 in 0049cb8
but, until I'm sure that that doesn't have unintended side effects, this should at least catch the case of trying to rebuild a submenu that has just been disposed of.