Skip to content

ci: Add testing of napari/utils/_tests/test_key_bindings.py#173

Merged
tlambert03 merged 1 commit intopyapp-kit:mainfrom
Czaki:napari_test
Jan 7, 2024
Merged

ci: Add testing of napari/utils/_tests/test_key_bindings.py#173
tlambert03 merged 1 commit intopyapp-kit:mainfrom
Czaki:napari_test

Conversation

@Czaki
Copy link
Copy Markdown
Contributor

@Czaki Czaki commented Jan 7, 2024

Add more test to napari test to easier early find incompatybilites and earlier prepare napari repository for changes.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0f48b6) 100.00% compared to head (cb00b1b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1785      1785           
=========================================
  Hits          1785      1785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 7f853e6 into pyapp-kit:main Jan 7, 2024
@tlambert03
Copy link
Copy Markdown
Member

thanks @Czaki. For what it's worth, in this case, I don't think it would have been possible to both satisfy the request I had coming from napari devs in #108 while also keeping all of the tests in napari passing (even with a deprecation warning), since napari itself was asserting the very thing that devs were requesting to have changed

@Czaki
Copy link
Copy Markdown
Contributor Author

Czaki commented Jan 7, 2024

@tlambert03 in a situation like in #108 it will be enough to inform napari-devs that they need to fix tests in napari after such request.

This allows to not interrupt development workflow and keep working smooth.

@tlambert03
Copy link
Copy Markdown
Member

tlambert03 commented Jan 7, 2024

I didn’t know at the time that there were tests outside of your app-model folder that would be affected. Sorry, it’s probably just gonna happen from time to time that you need to make slight adjustments to your tests

@Czaki
Copy link
Copy Markdown
Contributor Author

Czaki commented Jan 7, 2024

Yes. The next known milestone is 6204 that need to be pushed just after 0.4.19 relese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants