ci: Add testing of napari/utils/_tests/test_key_bindings.py#173
ci: Add testing of napari/utils/_tests/test_key_bindings.py#173tlambert03 merged 1 commit intopyapp-kit:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 1785 1785
=========================================
Hits 1785 1785 ☔ View full report in Codecov by Sentry. |
|
thanks @Czaki. For what it's worth, in this case, I don't think it would have been possible to both satisfy the request I had coming from napari devs in #108 while also keeping all of the tests in napari passing (even with a deprecation warning), since napari itself was asserting the very thing that devs were requesting to have changed |
|
@tlambert03 in a situation like in #108 it will be enough to inform napari-devs that they need to fix tests in napari after such request. This allows to not interrupt development workflow and keep working smooth. |
|
I didn’t know at the time that there were tests outside of your app-model folder that would be affected. Sorry, it’s probably just gonna happen from time to time that you need to make slight adjustments to your tests |
|
Yes. The next known milestone is 6204 that need to be pushed just after 0.4.19 relese |
Add more test to napari test to easier early find incompatybilites and earlier prepare napari repository for changes.