fix: handle qmods like QT5 for pyside6 not 6.4#179
Merged
tlambert03 merged 2 commits intopyapp-kit:mainfrom Mar 18, 2024
Merged
fix: handle qmods like QT5 for pyside6 not 6.4#179tlambert03 merged 2 commits intopyapp-kit:mainfrom
tlambert03 merged 2 commits intopyapp-kit:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 1785 1786 +1
=========================================
+ Hits 1785 1786 +1 ☔ View full report in Codecov by Sentry. |
Member
|
works for me. fwiw, i think the underlying cause here is the fact that the behavior of if isinstance(key, int):
key = QKeyCombination.fromCombined(key)which is a generic (Qt6+) way to cast an integer to a |
Member
|
@psobolewskiPhD, we're now testing everything from Qt 5.15; 6.2-6.6 #180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're trying to Goldilocks a pyside6 version for napari tests.
Recently (napari/napari#6738) when testing with pyside6 6.3.1, we got this failure:
https://github.com/napari/napari/actions/runs/8303510051/job/22727974608?pr=6738#step:12:209
In this PR, for versions of pyside6 before 6.4, just use the QT5 handling.
I tested locally with pyside 6.3.1, and latest, as well as pyqt6 6.3.1 and latest.