Skip to content

fix: Use QApplication instance as a parent of global actions#246

Merged
tlambert03 merged 1 commit intopyapp-kit:mainfrom
Czaki:qapp_parent
Jun 18, 2025
Merged

fix: Use QApplication instance as a parent of global actions#246
tlambert03 merged 1 commit intopyapp-kit:mainfrom
Czaki:qapp_parent

Conversation

@Czaki
Copy link
Copy Markdown
Contributor

@Czaki Czaki commented Jun 18, 2025

Closes #245

I tested it locally, do not have an idea how to test it on CI.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (06c1bc4) to head (75d8ed9).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1922      1923    +1     
=========================================
+ Hits          1922      1923    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
Copy link
Copy Markdown
Member

slight preference for this over #247, since A) it still gives the action a parent, which is nice for app-level cleanup, and B) I wonder whether tying the actions to a Menu or Toolbar is too specific?

@tlambert03 tlambert03 merged commit c038343 into pyapp-kit:main Jun 18, 2025
33 of 35 checks passed
@Czaki Czaki deleted the qapp_parent branch June 18, 2025 15:51
@tlambert03 tlambert03 added the bug Something isn't working label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

Singleton of Actions do not work with multiple windows of same application

2 participants