Skip to content

fix: use list of action in model to keep action live #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Czaki wants to merge 1 commit into from
Closed

fix: use list of action in model to keep action live #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/app_model/backends/qt/_qmenu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def __init__(
assert isinstance(menu_id, str), f"Expected str, got {type(menu_id)!r}"
self._menu_id = menu_id
self._app = Application.get_or_create(app) if isinstance(app, str) else app
self._action_list = [] # type: list[QAction]
self.setObjectName(menu_id)
self.rebuild()
self._app.menus.menus_changed.connect(self._on_registry_changed)
Expand Down Expand Up @@ -184,6 +185,7 @@ def __init__(
assert isinstance(menu_id, str), f"Expected str, got {type(menu_id)!r}"
self._menu_id = menu_id
self._app = Application.get_or_create(app) if isinstance(app, str) else app
self._action_list = [] # type: list[QAction]
self.setObjectName(menu_id)
self.rebuild()
self._app.menus.menus_changed.connect(self._on_registry_changed)
Expand Down Expand Up @@ -285,7 +287,7 @@ def update_from_context(self, ctx: Mapping[str, object]) -> None:


def _rebuild(
menu: QMenu | QToolBar,
menu: QModelMenu | QModelToolBar,
app: Application,
menu_id: str,
include_submenus: bool = True,
Expand All @@ -307,7 +309,9 @@ def _rebuild(
submenu = QModelSubmenu(item, app, parent=menu)
cast("QMenu", menu).addMenu(submenu)
elif item.command.id not in _exclude:
action = QMenuItemAction.create(item, app=app, parent=menu)
action = QMenuItemAction.create(item, app=app)
if action not in menu._action_list:
menu._action_list.append(action)
menu.addAction(action)
if n < n_groups - 1:
menu.addSeparator()
Expand Down
Loading