fix: fix pydantic deprecation warning#269
Merged
tlambert03 merged 8 commits intopyapp-kit:mainfrom Nov 9, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 99.68% 99.62% -0.06%
==========================================
Files 31 31
Lines 1877 1878 +1
==========================================
Hits 1871 1871
- Misses 6 7 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tlambert03
pushed a commit
that referenced
this pull request
Nov 9, 2025
The Pydantic 2.12+ deprecation warning asks to convert @model_validator with mode='after' from a classmethod to an instance method, NOT to change from mode='after' to mode='before'. The PR #269's approach of using mode='before' was incorrect and caused issues with PySide because: - mode='before' receives raw input before Pydantic processes it - Returning an already-constructed instance from a 'before' validator interferes with Pydantic's validation flow - This manifests differently with PySide vs PyQt due to Qt type handling This fix: - Keeps mode='after' as Pydantic recommends - Changes from classmethod to instance method - Simplifies the validator to a no-op (returns self) - Fixes the PySide test failures - Removes the deprecation warning Fixes #268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #268