Closed
Conversation
Author
|
Ooh, interesting, now I'm reading #108. Maybe this wasn't the best approach, let me take another stab when I next get a chance 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I was experimenting with this repo over in scenex for its key bindings model, and I was finding it tedious to check key binding equality. For example, if I want to know whether the left arrow was pressed, it'd be nice to say "kb == KeyCode.LeftArrow`, but that does not work as is. Was wondering whether a syntax like the following would be problematic?
Of course, if we like more "magical" equality checks, there are probably more things to do. Other equality checks, hashing checks, etc.