Skip to content

A bit more consistent SignalGroup iter#289

Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom
getzze:correct-group-iter
Mar 11, 2024
Merged

A bit more consistent SignalGroup iter#289
tlambert03 merged 3 commits intopyapp-kit:mainfrom
getzze:correct-group-iter

Conversation

@getzze
Copy link
Contributor

@getzze getzze commented Mar 6, 2024

No description provided.

@getzze getzze changed the title Uuse self._psygnal_instances consistently A bit more consistent SignalGroup iter Mar 6, 2024
@codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f4ac7c3) to head (f8e9906).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #289   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1930      1933    +3     
=========================================
+ Hits          1930      1933    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2024

CodSpeed Performance Report

Merging #289 will improve performances by 13.72%

Comparing getzze:correct-group-iter (f8e9906) with main (f4ac7c3)

Summary

⚡ 1 improvements
✅ 65 untouched benchmarks

Benchmarks breakdown

Benchmark main getzze:correct-group-iter Change
test_emit_time[lambda-2] 127.9 µs 112.5 µs +13.72%

@tlambert03 tlambert03 marked this pull request as ready for review March 10, 2024 16:05
@tlambert03
Copy link
Member

looks good to me! thanks @getzze.
side question: I notice you mark most of your PRs as draft, and don't seem to mark them as ready for review. Should I assume that they're ready to go if all tests are passing and you haven't touched it for a few days?

@getzze
Copy link
Contributor Author

getzze commented Mar 11, 2024

I'm not 100% when to use draft or not, but this PR is not a draft indeed :)

@tlambert03 tlambert03 merged commit 5d19031 into pyapp-kit:main Mar 11, 2024
@tlambert03 tlambert03 added the bug Something isn't working label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants