Draft
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (82.48%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 88.33% 88.04% -0.29%
==========================================
Files 62 64 +2
Lines 3060 3162 +102
==========================================
+ Hits 2703 2784 +81
- Misses 357 378 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As these events become more general we should use broader language
gselzer
commented
Apr 10, 2026
Comment on lines
72
to
+76
| def _on_view_event(event: Event) -> bool: | ||
| if isinstance(event, MouseMoveEvent): | ||
| intersections = event.world_ray.intersections(view.scene) | ||
| if (ray := view.to_ray(event.pos)) is None: | ||
| return False | ||
| intersections = ray.intersections(view.scene) |
Collaborator
Author
There was a problem hiding this comment.
I'm really left wanting for something better than this. We need a way to go from "here's an event" to "here are all of the nodes that pertain to this event"
Will keep thinking on it. Suggestions appreciated too by any passers-by!
Want to be able to play with these things. Likely will try moving to app-model at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
KeyPressEventandKeyReleaseEventwith the goal of enabling keyboard shortcuts in downstream tools such as ndv.Key events are modeled using app-model's
KeyBindingtype. Longer-term, we should consider upstreaming pieces of the events system to app-model.This PR also makes some minor refactors to the events model (e.g. renaming
canvas_pos→pos,world_rayremoved fromMouseEventbase) in the pursuit of more general events that can be used byCanvasevent filters now and maybe upstream in app-model later.What's included
KeyPressEventandKeyReleaseEventevent typeskeyboard_pan_zoom.pyTODO
CameraControllers