Merged
Conversation
It switches to anywidget, which is great, except for a couple of bugs that break usage. See vispy/jupyter_rfb#148 and also kinda vispy/jupyter_rfb#151. Once both of those are resolved (currently only the first is) we should just enforce a new minimum bound >1.0.2. And then we may want to consider renaming the jupyter backend, because anywidget might be better.
Member
|
It's definitely better! pyapp-kit/ndv#273 is doing all kinds of fun things, including vscode, marimo, and other things that have been hard until now |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 62 62
Lines 2950 2950
=======================================
Hits 2600 2600
Misses 350 350 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It switches to anywidget, which is great, except for a couple of bugs that break usage. See vispy/jupyter_rfb#148 and also kinda vispy/jupyter_rfb#151. Once both of those are resolved (currently only the first is) we should just enforce a new minimum bound >1.0.2.
And then we may want to consider renaming the jupyter backend, because anywidget might be better.