#1110 fix bug#1111
Merged
valentinsulzer merged 2 commits intodevelopfrom Jul 24, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1111 +/- ##
===========================================
- Coverage 97.82% 97.82% -0.01%
===========================================
Files 245 245
Lines 13273 13271 -2
===========================================
- Hits 12984 12982 -2
Misses 289 289
Continue to review full report at Codecov.
|
brosaplanella
approved these changes
Jul 24, 2020
Member
brosaplanella
left a comment
brosaplanella
left a comment
There was a problem hiding this comment.
Looks good, just a minor comment on the DFN script
| t_eval = np.linspace(0, 3600, 100) | ||
| solver = pybamm.CasadiSolver(atol=1e-6, rtol=1e-3) | ||
| solution = solver.solve(model, t_eval) | ||
| solution = solver.solve(model, t_eval, inputs={"eps_n": 0.3}) |
Member
There was a problem hiding this comment.
I think it would be better to keep the DFN example without inputs, we can have a separate example for this.
Member
Author
There was a problem hiding this comment.
yes, forgot to remove this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix setting a FunctionParameter with an InputParameter
Fixes #1110
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: