Lfp parameters

[valentinsulzer]

Description

Add parameters for A123 LFP cells

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[valentinsulzer]

@all-contributors add @dalbamont for code

[allcontributors]

@tinosulzer

I've put up a pull request to add @dalbamont! 🎉

[codecov]

Codecov Report

Merging #1209 into develop will increase coverage by 0.00%.
The diff coverage is 98.14%.

@@           Coverage Diff            @@
##           develop    #1209   +/-   ##
========================================
  Coverage    97.93%   97.93%           
========================================
  Files          247      249    +2     
  Lines        14048    14062   +14     
========================================
+ Hits         13758    13772   +14     
  Misses         290      290           

Impacted Files	Coverage Δ
..._battery_models/lithium_ion/basic_dfn_half_cell.py	99.21% <ø> (ø)
...odels/full_battery_models/lithium_ion/basic_spm.py	100.00% <ø> (ø)
pybamm/expression_tree/operations/evaluate.py	97.14% <95.45%> (ø)
pybamm/solvers/jax_bdf_solver.py	99.04% <98.27%> (ø)
...ctrolyte_exchange_current_density_kashkooli2017.py	100.00% <100.00%> (ø)
...m-ion/cathodes/LFP_Prada2013/LFP_ocp_ashfar2017.py	100.00% <100.00%> (ø)
pybamm/meshes/one_dimensional_submeshes.py	100.00% <100.00%> (ø)
pybamm/parameters/parameter_sets.py	100.00% <100.00%> (ø)
pybamm/solvers/jax_solver.py	98.14% <100.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f594b2...90250c4. Read the comment docs.

[brosaplanella]

Very nice work, just a few changes before we can merge. Also, take a look at the codacy report as there are two issues (basically a blank space and a blank line).

[valentinsulzer]

Thanks @brosaplanella for all those good catches!

[brosaplanella]

Looks good, thanks @tinosulzer and @dalbamont!