Remove 32 bits support

[Saransh-cpp]

Description

Removed support for Windows 32-bits from workflows. Additionally, all the CMakeLists.txt files had some conditions for 32-bit windows, and I am not sure if they should be removed. The tests are passing when these lines are removed but I'll revert the deletions if they are supposed to stay.

PyBaMM/scripts/replace-cmake/sundials-4.1.0/CMakeLists.txt

Lines 322 to 331 in 9f8f2c3

	IF(BUILD_SHARED_LIBS AND WIN32)
	SET(SUNDIALS_EXPORT
	"#ifdef BUILD_SUNDIALS_LIBRARY
	#define SUNDIALS_EXPORT __declspec(dllexport)
	#else
	#define SUNDIALS_EXPORT __declspec(dllimport)
	#endif")
	ELSE(BUILD_SHARED_LIBS AND WIN32)
	SET(SUNDIALS_EXPORT "#define SUNDIALS_EXPORT")
	ENDIF(BUILD_SHARED_LIBS AND WIN32)

Fixes #1955

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #1964 (9089a78) into develop (5473db5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1964   +/-   ##
========================================
  Coverage    99.32%   99.32%           
========================================
  Files          346      346           
  Lines        19058    19058           
========================================
  Hits         18930    18930           
  Misses         128      128           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5473db5...9089a78. Read the comment docs.

[valentinsulzer]

Thanks! I think you can delete those lines. Is there a way to raise an error if the system is 32-bit windows, saying we no longer support it?

[Saransh-cpp]

Installing the latest version of PyBaMM using pip on Windows 32-bit will automatically raise an error. Older versions would work with the 32-bit system. I'm not sure if we should add a warning for them, or if we can even do so?

[valentinsulzer]

Yes, older versions should continue to work