Remove .id#1978
Merged
valentinsulzer merged 13 commits intodevelopfrom Jun 8, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1978 +/- ##
===========================================
- Coverage 99.38% 99.38% -0.01%
===========================================
Files 348 348
Lines 19255 19228 -27
===========================================
- Hits 19136 19109 -27
Misses 119 119
Continue to review full report at Codecov.
|
brosaplanella
approved these changes
Jun 7, 2022
Member
brosaplanella
left a comment
brosaplanella
left a comment
There was a problem hiding this comment.
Looks good, just a couple of small comments. Thanks Valentin!
| for var, julia_id in variable_to_print_name.items(): | ||
| # e.g. boundary_value_right(cache_123456789) gets replaced with u1(t, 1) | ||
| cache_var_id = id_to_julia_variable(var_id, "cache") | ||
| cache_var_id = id_to_julia_variable(var.id, "cache") |
Member
There was a problem hiding this comment.
I am a bit confused, why is the .id here now?
Member
Author
There was a problem hiding this comment.
we still need id here to generate names like cache_12345. I guess it could go into the id_to_julia_variable function
Member
There was a problem hiding this comment.
Ah, I get it. Looks good then!
| for var, julia_id in variable_to_print_name.items(): | ||
| # e.g. boundary_value_right(cache_123456789) gets replaced with u1(t, 1) | ||
| cache_var_id = id_to_julia_variable(var_id, "cache") | ||
| cache_var_id = id_to_julia_variable(var.id, "cache") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
__eq__and__hash__methods forpybamm.Symbol(possible now we're not using anytree)Replaces
symbol.idwithsymbolin dictionary keys and for equality checking, where possibleType of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: