fix shape for 2d interpolant#2180
Merged
valentinsulzer merged 4 commits intodevelopfrom Jul 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2180 +/- ##
========================================
Coverage 99.35% 99.35%
========================================
Files 356 356
Lines 19357 19359 +2
========================================
+ Hits 19233 19235 +2
Misses 124 124
Continue to review full report at Codecov.
|
rtimms
approved these changes
Jul 19, 2022
rtimms
approved these changes
Jul 19, 2022
| ) | ||
| if x2 is not None and x2.shape[0] != y.shape[0]: | ||
| raise ValueError( | ||
| "len(x2) should equal y=shape[2], " |
Contributor
There was a problem hiding this comment.
the text in this error doesn’t match the if statement, otherwise all good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug in 2D interpolant