Skip to content

Voltage components#2183

Merged
valentinsulzer merged 11 commits intodevelopfrom
voltage-components
Jul 26, 2022
Merged

Voltage components#2183
valentinsulzer merged 11 commits intodevelopfrom
voltage-components

Conversation

@valentinsulzer
Copy link
Copy Markdown
Member

Description

  • Fixes ylims in plot_voltage_components
  • Fixes labels

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2022

Codecov Report

Merging #2183 (33ac958) into develop (3fb5877) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2183   +/-   ##
========================================
  Coverage    99.35%   99.35%           
========================================
  Files          347      347           
  Lines        19240    19241    +1     
========================================
+ Hits         19116    19117    +1     
  Misses         124      124           
Impacted Files Coverage Δ
pybamm/plotting/plot_voltage_components.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb5877...33ac958. Read the comment docs.

Copy link
Copy Markdown
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit 9856785 into develop Jul 26, 2022
@valentinsulzer valentinsulzer deleted the voltage-components branch July 26, 2022 17:48
@brosaplanella
Copy link
Copy Markdown
Member

BTW, just noticed that this didn't have an entry in the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants