Composite release#2256
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## develop #2256 +/- ##
=========================================
Coverage 99.38% 99.39%
=========================================
Files 359 365 +6
Lines 19821 20011 +190
=========================================
+ Hits 19699 19889 +190
Misses 122 122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
brosaplanella
left a comment
brosaplanella
left a comment
There was a problem hiding this comment.
Looks good! The new models should be added to the docs though.
|
|
||
| return ( | ||
| m_ref * arrhenius * c_e ** 0.5 * c_s_surf ** 0.5 * (c_s_max - c_s_surf) ** 0.5 | ||
| m_ref * arrhenius * c_e**0.5 * c_s_surf**0.5 * (c_s_max - c_s_surf) ** 0.5 |
There was a problem hiding this comment.
How come some ** don't have spaces and some do? (note this applies to quite a few files)
There was a problem hiding this comment.
I have no idea. Maybe we should have github actions run black on all pushes to avoid things like this (@priyanshuone6 can you set that up?)
There was a problem hiding this comment.
It is interesting that flake8 is not complaining though
There was a problem hiding this comment.
Should black run on all the files or only the pushed commits?
|
I've added the OCP models to the docs |
5 participants
Description
Adds silicon/graphite composite model, using the two-phase changes from #2133
Adds current sigmoid OCP submodel
Fixes #1433
Fixes #2052
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: