fix: pybamm.have_julia is True when PyCall.jl uninstalled#2402
fix: pybamm.have_julia is True when PyCall.jl uninstalled#2402valentinsulzer merged 5 commits intopybamm-team:developfrom awadell1:have_julia
Conversation
Currently `pybamm.have_julia()` returns True even if PyCall.jl is not configured this results in test failures as the tests assume they can call: ```python from julia.api import Julia Julia() ``` Which fails if Julia has not actually been configured. This commit fixes that
valentinsulzer
left a comment
There was a problem hiding this comment.
Thanks, will probably need to update this soon / coordinate with @abillscmu as we switch to pythoncall
|
I'll add a test but this should be obsolete when #2363 is merged. |
Codecov ReportBase: 99.66% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2402 +/- ##
===========================================
+ Coverage 99.66% 99.72% +0.05%
===========================================
Files 269 268 -1
Lines 20190 20153 -37
===========================================
- Hits 20123 20097 -26
+ Misses 67 56 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Per conv with @tinosulzer have exempted missed branches from coverage reporting
Currently
pybamm.have_julia()returns True even if PyCall.jl is not configured this results in test failures as the tests assume they can call:Which fails if Julia has not been configured. This commit fixes that.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: