Asymmetric SEI reaction

[brosaplanella]

Description

Allow for asymmetric SEI reactions, in the cases of "reaction limited" and "ec reaction limited". The option is set to "reaction limited (symmetric)" and "reaction limited (asymmetric)" (same for EC).

Fixes #2338

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Base: 99.71% // Head: 99.71% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c7b522e) compared to base (2b882d2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2425   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          267      267           
  Lines        20044    20048    +4     
========================================
+ Hits         19987    19991    +4     
  Misses          57       57           

Impacted Files	Coverage Δ
...m/models/full_battery_models/base_battery_model.py	99.79% <ø> (ø)
pybamm/models/submodels/interface/sei/base_sei.py	100.00% <100.00%> (ø)
...ybamm/models/submodels/interface/sei/sei_growth.py	100.00% <100.00%> (ø)
pybamm/parameters/lithium_ion_parameters.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[valentinsulzer]

Changes look good, I think the symmetric option name shouldn't change though, since it's a breaking change

[brosaplanella]

Changes look good, I think the symmetric option name shouldn't change though, since it's a breaking change

Which should it be?

1. "reaction limited" and "reaction limited (asymmetric)"
2. "reaction limited", "reaction limited (symmetric)" and "reaction limited (asymmetric)", where the first two are equivalent

First one is easier, but less informative.

[valentinsulzer]

Option 1

[valentinsulzer]

Thanks, looks good!