Issue #2457 make jupyter a dev only dependency

[arjxn-py]

Description

Made jupyter a development only dependency instead of required dependency.

Fixes #2457

Type of change

Jupyter has been moved from required dependency to development only dependency in requirements.txt & setup.py and also been added as a testing dependency in tox.ini.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all
• The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (08dc8f7) 99.69% compared to head (ba89a07) 99.69%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2846   +/-   ##
========================================
  Coverage    99.69%   99.69%           
========================================
  Files          273      273           
  Lines        19065    19065           
========================================
  Hits         19006    19006           
  Misses          59       59           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[arjxn-py]

@tinosulzer I have listed the packages that were dependent on Jupyter in required dependencies but now the tests are failing while running example notebooks most likely on this line - %pip install pybamm -q giving syntax error.
I would be grateful If I could get some suggestion on it.

[valentinsulzer]

you should install jupyter in tox.ini before running the example tests

[arjxn-py]

@tinosulzer Thankfully, almost all the tests are passing now. Though i'm not sure about the Lynchee one.

[valentinsulzer]

won't jupyter install nbconvert (i.e. no need to make explicit)

[arjxn-py]

won't jupyter install nbconvert (i.e. no need to make explicit)

I listed it to avoid the potential risk to examples tests failing, but yes jupyter should install nbconvert with it so I am looking into it.
Thanks for suggesting.

[arjxn-py]

One of the integration test is failing but I don't think I've made any changes in that regard.

[Saransh-cpp]

Thanks, @arjxn-py! Looks good to me!

[valentinsulzer]

Can you update changelog (add this as a breaking change)?

[arjxn-py]

Can you update changelog (add this as a breaking change)?

Yes i'll do that.