Support Python 3.12#3531
Conversation
for PyPI pushes, scheduled tests, and tests on PRs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3531 +/- ##
========================================
Coverage 99.59% 99.59%
========================================
Files 258 258
Lines 20755 20755
========================================
Hits 20670 20670
Misses 85 85 ☔ View full report in Codecov by Sentry. |
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks @agriyakhetarpal! I think it would be better to remove the install_PyBaMM function because I think the function is redundant and is complicating simple things.
|
I have now removed the |
|
@agriyakhetarpal could you rebase this? |
I just noticed this comment—I think there will be many merge conflicts here and there and they will be repeated a lot as the latest changes are added upstream—perhaps I can rebase this branch here on top of the changes in #3550, or just wait for #3550 to be reviewed and get merged first. I haven't worked on the installation guide yet to adjust for both of the PRs since they will require changes to it, but I shall do that as soon as possible next week. |
arjxn-py
left a comment
There was a problem hiding this comment.
Thanks @agriyakhetarpal, looks good.
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks, @agriyakhetarpal! This should also remove all the instances of distutils from the codebase. We are importing distutils in setup.py at the moment.
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks, @agriyakhetarpal! Looks good!
Description
Related to #3390. Adds support for Python 3.12 across the repository
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: