Skip to content

Don't be too strict with func_args longer than symbol.children#5274

Merged
valentinsulzer merged 5 commits intopybamm-team:developfrom
agriyakhetarpal:roundtrip-serialisation-fix
Nov 20, 2025
Merged

Don't be too strict with func_args longer than symbol.children#5274
valentinsulzer merged 5 commits intopybamm-team:developfrom
agriyakhetarpal:roundtrip-serialisation-fix

Conversation

@agriyakhetarpal
Copy link
Copy Markdown
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #5273

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@agriyakhetarpal agriyakhetarpal requested a review from a team as a code owner November 13, 2025 03:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (af64ddd) to head (eda4ebe).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5274   +/-   ##
========================================
  Coverage    98.77%   98.77%           
========================================
  Files          321      321           
  Lines        27727    27729    +2     
========================================
+ Hits         27387    27389    +2     
  Misses         340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much!

@valentinsulzer valentinsulzer merged commit 86fec31 into pybamm-team:develop Nov 20, 2025
22 checks passed
@agriyakhetarpal agriyakhetarpal deleted the roundtrip-serialisation-fix branch November 21, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Serialization with keyword args

2 participants