Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5397 +/- ##
==========================================
- Coverage 98.29% 94.39% -3.91%
==========================================
Files 337 342 +5
Lines 30950 33243 +2293
==========================================
+ Hits 30423 31379 +956
- Misses 527 1864 +1337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolve conflicts: - __init__.py: keep both VTKQuickPlot and nyquist_plot imports - functions.py: take main's Max/Min _casadi_evaluate and _evaluate_for_shape - convert_to_casadi.py: accept deletion from main's OOP refactor; port VectorField casadi conversion to _to_casadi method on the class
- vector_field.py: 85% -> 100% - tensor_field.py: 90% -> 100% - unstructured_submesh.py: 64% -> 87% Added tests for quad/hex element types, boundary loops, contains_points_3d on hex, optimize_ordering on single cell, generator error paths, and _parse_lims string-variable handling. Added tensor/vector field getitem edge cases, all-on-edges path, and VectorField._to_casadi coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an unstructured finite volume method for 2 and 3D, allowing for simulations on arbitrary domains with user-provided meshes.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests