Issue 546 convection#635
Merged
valentinsulzer merged 81 commits intodevelopfrom Apr 9, 2020
Merged
Conversation
rtimms
approved these changes
Apr 8, 2020
| ---------- | ||
| p : :class:`pybamm.Symbol` | ||
| The fluid pressure | ||
| v_box : :class:`pybamm.Symbol` |
Contributor
There was a problem hiding this comment.
this just takes in variables now
| ---------- | ||
| dV_box_dz : :class:`pybamm.Symbol` | ||
| The vertical velocity of the fluid | ||
| p : :class:`pybamm.Symbol` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Started off as an issue for convection and became the home of all thesis hacks. Hopefully not too much of a nightmare to merge.
Fixes #546
Type of change
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: