Conversation
added 2 commits
October 10, 2019 12:10
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
+ Coverage 98.49% 98.49% +<.01%
==========================================
Files 167 167
Lines 8179 8180 +1
==========================================
+ Hits 8056 8057 +1
Misses 123 123
Continue to review full report at Codecov.
|
valentinsulzer
approved these changes
Oct 10, 2019
Member
valentinsulzer
left a comment
There was a problem hiding this comment.
looks good to me, thanks @rtimms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't unnecessarily check that the slice size exceeds the child size when making a new copy of an Index node
Fixes #655
Please delete options that are not relevant.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: