Issue 570 processed var warning#681
Merged
valentinsulzer merged 5 commits intomasterfrom Oct 25, 2019
Merged
Conversation
rtimms
approved these changes
Oct 25, 2019
Contributor
rtimms
left a comment
rtimms
left a comment
There was a problem hiding this comment.
looks great thanks @tinosulzer !
rtimms
reviewed
Oct 25, 2019
|
|
||
| # Create a custom logger | ||
| logger = logging.getLogger(__name__) | ||
| set_logging_level("WARNING") |
Contributor
There was a problem hiding this comment.
looks like the test_logger test needs updating as the default logger level has changed
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 98.56% 98.56% +<.01%
==========================================
Files 170 170
Lines 8517 8521 +4
==========================================
+ Hits 8395 8399 +4
Misses 122 122
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add warning if processed variable is called outside range
Fixes #570
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: