Merged
Conversation
added 13 commits
October 25, 2019 09:04
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 98.52% 98.49% -0.03%
==========================================
Files 175 175
Lines 8861 8929 +68
==========================================
+ Hits 8730 8795 +65
- Misses 131 134 +3
Continue to review full report at Codecov.
|
valentinsulzer
approved these changes
Oct 31, 2019
Member
valentinsulzer
left a comment
valentinsulzer
left a comment
There was a problem hiding this comment.
Looks great, thanks @rtimms !
|
|
||
| variables = { | ||
| domain + " electrolyte current density": i_e, | ||
| domain + " electrolyte current density [V]": i_e * i_typ, |
| """ | ||
| Computes the y-z average by integration over y and z | ||
| In this case this is just equal to the input variable | ||
| """ |
Member
There was a problem hiding this comment.
my man fixing comment formatting ⭐️
Scottmar93
approved these changes
Oct 31, 2019
Contributor
Scottmar93
left a comment
Scottmar93
left a comment
There was a problem hiding this comment.
All looks good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing temperature dependence in electrolyte and interface submodels
Fixes #678
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: