#591 fix entropic change bug

[rtimms]

Description

Fixes a bug where the dimensional open circuit potential was being evaluated using the non-dimensional temperature instead of the dimensional temperature.

Also removed the params such as "Typical diffusivity..." etc from the csv files if a function has been provided. The typical coefficient is hard coded into the function, so changing the value in the csv had no effect and could potentially be confusing for users.

Fixes #591

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #702 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   98.26%   98.26%   +<.01%     
==========================================
  Files         176      176              
  Lines        9106     9108       +2     
==========================================
+ Hits         8948     8950       +2     
  Misses        158      158

Impacted Files	Coverage Δ
...bamm/parameters/standard_parameters_lithium_ion.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d2b41...f355432. Read the comment docs.

[brosaplanella]

I have checked and solves the problem. Thanks Rob!