Issue 492 potentiostatic#751
Merged
valentinsulzer merged 38 commits intomasterfrom Dec 14, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
- Coverage 98.39% 98.35% -0.04%
==========================================
Files 176 179 +3
Lines 9701 9810 +109
==========================================
+ Hits 9545 9649 +104
- Misses 156 161 +5
Continue to review full report at Codecov.
|
rtimms
approved these changes
Dec 13, 2019
Contributor
rtimms
left a comment
rtimms
left a comment
There was a problem hiding this comment.
this looks great, thanks @tinosulzer !
| Upper voltage cut-off [V],2.44,,(just over) 14.5V across 6-cell battery | ||
| C-rate,1,, | ||
| Current function,[constant],, | ||
| C-rate,0.1,, |
Member
Author
There was a problem hiding this comment.
one of the tests failed when it was 1C so I just lazily changed it so 0.1C, don't really care about lead-acid any more ...
| ,,, | ||
| # Electrical,,, | ||
| Cell capacity [A.h],0.680616,,24 Ah/m2 * 0.137m * 0.207m | ||
| Typical current [A],1.46925726107,,1C current |
Contributor
There was a problem hiding this comment.
should this just be equal to the cell capacity?
| from .base_external_circuit import BaseModel, LeadingOrderBaseModel | ||
|
|
||
|
|
||
| class FunctionControl(BaseModel): |
| def check_and_update_parameter_values(self, values): | ||
| # Make sure "C-rate" and current are both non-zero | ||
| if "C-rate" in values and values["C-rate"] == 0: | ||
| # Make typical current is non-zero |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add models for voltage-controlled and power-controlled discharge
Fixes #492
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: