Issue 802 porosity#809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 179 179
Lines 9919 9919
=======================================
Hits 9735 9735
Misses 184 184
Continue to review full report at Codecov.
|
| eps_s = pybamm.PrimaryBroadcast(param.epsilon_s, "separator") | ||
| eps_p = pybamm.PrimaryBroadcast(param.epsilon_p, "positive electrode") | ||
| eps_n = pybamm.PrimaryBroadcast( | ||
| pybamm.Parameter("Negative electrode porosity"), "negative electrode" |
There was a problem hiding this comment.
Sort of feel we should be defining these parameters inside the standard parameter file? Maybe that conflicts with the spatially dependent ones though...
There was a problem hiding this comment.
I agree with Scott. It would be good to pass it as a function or dataset, as with other parameters.
There was a problem hiding this comment.
yeah, the problem is that param.epsilon_s now has domain "separator" and secondary domain "current collector", and so we would need to add "current collector" as a secondary domain to everything to avoid shape errors (tbh this should probably be automatic), and adding current collector to everything is unnecessarily complicated for this model
3 participants
Description
Allow porosity to vary in space
Fixes #802
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: