Conversation
valentinsulzer
approved these changes
May 13, 2020
Member
valentinsulzer
left a comment
There was a problem hiding this comment.
Looks great, cheers.
If we add more of these methods to query the model we should think about making it a single function to reduce repeated code, but it's fine for now
Codecov Report
@@ Coverage Diff @@
## develop #993 +/- ##
========================================
Coverage 97.55% 97.56%
========================================
Files 233 233
Lines 12083 12106 +23
========================================
+ Hits 11788 11811 +23
Misses 295 295
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an attribute
parametersto the model that lists all of the parameters (similar to the attributeinput_parameters). Also addparametersattribute to geometry. Now users can see which parameters a model requires by doingmodel.parameters(before it is processed). Note: this is different tomodel.paramwhich is the module of parameters that model uses.Also removes parameters related to tabs that aren't correct for a given set (they were inadvertently copied from the Marquis2019 set)
Fixes #964
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: