Issue 984 butler volmer resistance#994
Merged
valentinsulzer merged 19 commits intodevelopfrom May 19, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #994 +/- ##
===========================================
+ Coverage 97.56% 97.58% +0.01%
===========================================
Files 232 234 +2
Lines 12119 12251 +132
===========================================
+ Hits 11824 11955 +131
- Misses 295 296 +1
Continue to review full report at Codecov.
|
brosaplanella
approved these changes
May 16, 2020
Member
brosaplanella
left a comment
There was a problem hiding this comment.
Thanks Tino! It looks great :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix some bugs in the SEI submodels and add the SEI film resistance.
Note: we may want to think about the nondimensionalisation for the SEI a bit more
Fixes #984
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: