Add enum value to enum repr#2126
Conversation
auscompgeek
force-pushed
the
repr-enum-value
branch
from
f6e83cf to
b38a0be
Compare
YannickJadoul
left a comment
YannickJadoul
left a comment
There was a problem hiding this comment.
Looks good to me! :-)
|
|
||
| m_base.attr("__repr__") = cpp_function( | ||
| [](handle arg) -> str { | ||
| [](object arg) -> str { |
There was a problem hiding this comment.
Why handle to object? You don't need reference counting here, do you?
There was a problem hiding this comment.
Argh, good catch. I should've look more closely at the details rather than eyeballing the structural changes and shrugging "OK"...
There was a problem hiding this comment.
OK, so I just tried this out, and the reason seems to be because there's no int_ conversion from handle (you can reinterpret_steal/reinterpret_borrow, but those will not do the int(...) conversion).
There was a problem hiding this comment.
See e.g. __getstate__ and __hash__, also doing that. I don't immediately see a better solution, then? (though if feels there ought to be one, changing the interface of the Python types; but that's a different discussion/PR)
There was a problem hiding this comment.
Maybe pass the object by reference, to avoid reference counting?
There was a problem hiding this comment.
@bstaletic Hmmm, interesting.
Thinking about it a bit futher: will it, though? I believe (though the cast, make_caster, cast_op, PYBIND11_TYPE_CASTER, ... code is quite convoluted) that the object will be created and moved from the caster anyway, if you take it by value. So it shouldn't matter?
There was a problem hiding this comment.
I vote to keep it this way, merge this PR, and create an issue/discussion on why you can't call the int_ conversion on a handle (like you can for str).
YannickJadoul
force-pushed
the
repr-enum-value
branch
from
b38a0be to
77a72c0
Compare
|
I've taken the liberty to rebase your PR onto the latest |
|
Successfully rebased, it seems :-) Does @bstaletic still want to say something (as you were involved in the discussion?) Otherwise, this should be ready, @henryiii? |
This changes enum reprs to look like `<Enum.name: value>` similarly to the Python enum module. This keeps the str of enums as `Enum.name`, like the Python enum module.
YannickJadoul
force-pushed
the
repr-enum-value
branch
from
77a72c0 to
5b8da50
Compare
|
Another rebase, after #2510. If CI turns green, I'll merge. |
|
Thanks, @auscompgeek! |
Fixed in pybind#2510 but reintroduced on one line by pybind#2126
4 participants
This changes enum reprs to look like
<Enum.name: value>similarly tothe Python enum module.
This keeps the str of enums as
Enum.name, like the Python enum module.Ref: #2332