Fix an issue where the pybind::embedd target would link to an incorrect python lib #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct python lib * with find_package(Python3) it would link the wrong Python3::Pyhton3 instead of the correct Python3::Pyhton * with find_package(Python2) it would link the wrong Python2::Pyhton2 instead of the correct Python3::Pyhton Fix pybind#2664
Collaborator
|
Very close duplicate of #2662, it seems. But thanks for submitting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where the pybind::embedd target would link to an incorrect python lib
Fix #2664
Description
Fix an issue where the pybind::embedd target would link to an incorrect python lib
Changed the target
${_Python}::${_Python}to${_Python}::PythonSuggested changelog entry: