Fix erronous python error setting on failed cast#2684
Closed
albanD wants to merge 1 commit intopybind:masterfrom
Closed
Fix erronous python error setting on failed cast#2684albanD wants to merge 1 commit intopybind:masterfrom
albanD wants to merge 1 commit intopybind:masterfrom
Conversation
Collaborator
|
Cfr. #2682 (comment), this PR is more complex than the proposed workaround in #2422 (#2422 (comment)), but doesn't seem to handle all the subtleties regarding #2336. In order to fix #2682, I propose to stick to @bstaletic's minimal workaround, and fix #2336 after a more thorough investigation of the issue and its consequences. |
Contributor
Author
|
I do agree that it should be throwing. I opened this PR mostly so that you could see the concrete code I was talking about. |
Collaborator
|
Perfect. Thanks for the effort and investigation! And again apologies that I didn't make the link yesterday evening (evening/night for me, at least) :-) |
Contributor
Author
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed fix for #2682 if maintainers agree that this is the right thing to do.
Fix crash in test suite for both debug cpython 3.8 and 3.9
Suggested changelog entry:
Not sure how detailed the description below should be. Let me know if this needs updating.