Add test_namespace_visibility (experiment, not for merging)#4044
Closed
rwgk wants to merge 7 commits intopybind:masterfrom
Closed
Add test_namespace_visibility (experiment, not for merging)#4044rwgk wants to merge 7 commits intopybind:masterfrom
test_namespace_visibility (experiment, not for merging)#4044rwgk wants to merge 7 commits intopybind:masterfrom
Conversation
To answer the question: Is there a difference in behavior if some `__attribute__((visibility("hidden")))` are missing?
…s (purely to be more intuitive, it does not change anything substantial).
Collaborator
Author
|
Summary of results for commit 3f01275: |
Collaborator
Author
|
To explain: The dynamic loaders behave differently on macOS (1st line above) vs Linux (2nd line). If a namespace has
Note that this is withOUT |
Collaborator
Author
|
The code added here was moved to separate files (tests/namespace_visibility) under PR #4050. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To answer the question: Is there a difference in behavior if some
__attribute__((visibility("hidden")))are missing (PR #4043)?A second motivation for this experiment was to gain clarity about Google-internal vs external behavior.
Suggested changelog entry: