Merged
Conversation
alex
previously approved these changes
Feb 14, 2024
Member
|
@mhils any idea what's going on with the mitmproxy tests? |
Member
|
@alex: thanks for the heads-up. This is likely caused by mitmproxy/mitmproxy@2a82674 - I'll make the tests OpenSSL version-agnostic tonight. :) |
Member
|
Thanks
…On Wed, Feb 14, 2024 at 4:18 AM Maximilian Hils ***@***.***> wrote:
@alex <https://github.com/alex>: thanks for the heads-up. This is likely
caused by ***@***.***
<mitmproxy/mitmproxy@2a82674>
- I'll make the tests OpenSSL version-agnostic tonight. :)
—
Reply to this email directly, view it on GitHub
<#10391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBACWGWRKWYFUJYPMTLYTR6QFAVCNFSM6AAAAABDHMEUVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTGM2TSOJUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
pyca-boringbot
bot
force-pushed
the
create-pull-request/patch
branch
from
0e5e27d to
b913cbc
Compare
mhils
added a commit
to mitmproxy/mitmproxy
that referenced
this pull request
Feb 15, 2024
This re-adds some log messages adjusted in 2a82674. We shouldn't fail tests for this. refs pyca/cryptography#10391
reaperhulk
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoringSSL
Commit: ba5eb621d7d9bf2872386b4303fd5e9aa64f7230
Diff between the last commit hash merged to this repository and the new commit.
OpenSSL
Commit: d597b46f9bdb533761e36fcf1d96ce83f3f6f04d
Diff between the last commit hash merged to this repository and the new commit.