Merged
Conversation
- Update branch names to match upstream - Drop py2 testing
Member
|
Looks like CI is failing. Is this related to this PR or was it pre-broken? |
Contributor
Author
|
Oh it was pre-broken, but I think I just pushed the piece to unbreak it while you were commenting |
alex
reviewed
Sep 30, 2021
Member
|
As long as we support that cryptography 3.3 minimum we should keep testing python 2.7, otherwise lgtm. |
Contributor
Author
|
Well, I don't really care about support for py2 or old cryptographys, but I'm happy to go with whatever. Does anyone care, or should we just toss them out and move on? |
As requested by @reaperhulk on IRC
reaperhulk
approved these changes
Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #1026 as requested.