This repository was archived by the owner on Sep 16, 2024. It is now read-only.
esp32/lteppp: Don't send CR each time when invoking "lteppp_send_at_cmd"#414
Closed
esp32/lteppp: Don't send CR each time when invoking "lteppp_send_at_cmd"#414
Conversation
@larox11 found this when trying to send AT+CSIM commands longer than 500 bytes to the modem. As the buffer behind this method is only 127 bytes long and the strcmp was evaluated erroneous, this stopped users sending longer commands in several chunks.
robert-hh
suggested changes
Feb 27, 2020
Contributor
robert-hh
left a comment
robert-hh
left a comment
There was a problem hiding this comment.
This change is wrong, since the +++ sequence must not be followed by NL. After +++ no other bytes must follow for a certain time. As far as I recall, for one second. The only appropriate change would be to allow for longer messages. But that is a larger change, affecting the buffer handling.
Contributor
Author
|
Thanks, @robert-hh. I will retract this change and close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@larox11 found this when trying to send AT+CSIM commands longer than 500 bytes to the modem. As the buffer behind this method is only 127 bytes long and the strcmp was evaluated erroneous, this stopped users sending longer commands in several chunks.
See also #411.