This repository was archived by the owner on May 24, 2023. It is now read-only.
Fixed directory creation on file download#220
Open
ftylitak wants to merge 3 commits intopycom:developfrom
Open
Fixed directory creation on file download#220ftylitak wants to merge 3 commits intopycom:developfrom
ftylitak wants to merge 3 commits intopycom:developfrom
Conversation
vitorcalvi
previously approved these changes
Nov 21, 2020
Contributor
|
Can you please merge with the latest Pymakr-atom (develop branch) and push changes to fix the tests? |
Author
|
Sorry for the many month delay. Hope now it is ready to be merged. |
Contributor
|
What's the status on this? |
Contributor
|
Task linked: CU-1hdmqha [Atom] fix issue with project resets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
While downloading the files contained in a Pycom device, the procedure generates errors due to inability to recursively create subfolders.
This error has already been fixed in the Pymakr for VS code by the commit pycom/pymakr-vsc@ee9b44e#diff-4526c02ea22c9a70285696db52fc53e6, so I applied the exact same code change.
Tested and working.
Does this close any currently open issues?
No.
Any relevant logs, error output, etc?
The stack trace is the following:
Any other comments?
No.
Where has this been tested?
Operating system:
Ubuntu 20.04 kernel 5.4.0-48-generic
Atom version:
1.51.0 x64
Pymakr version:
2.1.5